fix(gatsby-dev-cli): chmod gatsby bin on copy #19985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blainekasten
added
type: bug
blainekasten
force-pushed
the
fix/gatsby-dev-bin-permissions
branch
from
1e0a283
to
ab83dc5
Compare
pieh
approved these changes
Dec 6, 2019
| @@ -147,6 +156,7 @@ async function watch( | |||
| /\.git/i, | |||
| /\.DS_Store/, | |||
| /[/\\]__tests__[/\\]/i, | |||
| /[/\\]__mocks__[/\\]/i, | |||
pieh
added
the
bot: merge on green
|
I can't express just how happy I am to see this fixed! Thank you so much @blainekasten ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue is that yarn and npm will chmod a bin file on install. when gatsby-dev copies files over, the copied file needs to be chmod'd again.
Also in here, I noticed that gatsby-dev was copying over
__mocks__files, so those were added to the ignore list.Related Issues
Fixes #18809