fix(gatsby-source-filesystem): fix add/change text #20188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvdz
previously approved these changes
Dec 18, 2019
pieh
reviewed
Dec 18, 2019
wardpeet
force-pushed
the
fix/filesystem-message
branch
from
49cd7b2
to
b254ecc
Compare
pieh
reviewed
Dec 18, 2019
muescha
reviewed
Dec 18, 2019
Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>
|
Requesting changes to make sure this doesn't get merged as is, just in case the tests don't cover it. The last change was invalid. Not a syntax error but only because of a fluke. It'll be a runtime error for sure. |
pvdz
approved these changes
Dec 20, 2019
|
I'll do a manual test before I merge, just to be sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes info messages when filesystem detects changes. When a new file is created we use the
addword, when updating we use thechangedverb.This might lead to confusion
Related Issues
Fixes #17885