fix(docs): improve WordPress tutorial #20520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the dev url gets put to sleep after a period of inactivity and will throw a 503 error if someone tries to use it in this tutorial
this block of code shows `hostingWPCOM: false` below, so it doesn't make sense to use a wordpress.com url here
…otal beginners" This reverts commit 2b8a678.
gillkyle
reviewed
Jan 10, 2020
There was a problem hiding this comment.
This is so awesome, thanks a ton for helping out on this @TylerBarnes 😭🎉
I just pulled it to verify that the example site runs which is a great help. Looks like a lot of really worthwhile clarifications.
I looked at the WordPress sourcing recipe as well because that content is similar to this.
One thing I think could be updated is the README for the example. It currently says it's not a working example but seems to work great now 🙂
|
Thanks for mentioning that README @gillkyle . I updated it and removed the "important note" at the end as it doesn't seem to apply anymore. |
gillkyle
approved these changes
Jan 10, 2020
tcope25
added
the
type: documentation
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20080
I went through the tutorial locally and followed all the steps and made updates as I went through, then afterwards I followed all my updated steps again from scratch to make sure it's all working properly.
I noticed the demo url
dev-gatbsyjswp.pantheonsite.iodidn't actually work anymore. Since that was a dev site, pantheon froze it after a period of inactivity. I've launched the demo site tolive-gatbsyjswp.pantheonsite.ioand updated the URL here, that one wont freeze if it's inactive. I'm not sure how long the dev- site has been down for.I also noticed the README for
gatsby-source-wordpresshad a WordPress.org url listed in the plugin options example, but lower down hadhostingWPCOM: false. I updated that url tolive-gatbsyjswp.pantheonsite.iofor consistency as that site is a WordPress.org site.