Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-source-wordpress): Ability to set a custom rest api route prefix #20998

Conversation

crock
Copy link
Contributor

@crock crock commented Jan 29, 2020

Description

Adds a configuration option called restApiRoutePrefix that allows you to set a custom route prefix if one of your WordPress plugins changed it from wp-json. wp-json is left as the default value.

Related Issues

#20995

@crock crock requested a review from a team as a code owner January 29, 2020 17:13
@crock crock self-assigned this Jan 29, 2020
@pieh pieh changed the title [gatsby-source-wordpress] Ability to set a custom rest api route prefix feat(gatsby-source-wordpress): Ability to set a custom rest api route prefix Jan 31, 2020
Copy link
Contributor

@TylerBarnes TylerBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @crock! This is great, thank you for your contribution!!
Just one comment above. Once I fixed that locally it worked perfectly.

Can you also add a note to the README about the new plugin option?

@TylerBarnes TylerBarnes removed the request for review from paweljedrzejczyk February 2, 2020 21:26
@crock crock requested a review from a team as a code owner February 2, 2020 21:54
TylerBarnes
TylerBarnes previously approved these changes Feb 2, 2020
@TylerBarnes TylerBarnes added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Feb 2, 2020
gatsbybot added 2 commits February 2, 2020 22:57
…oute-prefix' of https://github.com/gatsbyjs/gatsby into feature/gatsby-source-wordpress/20995/custom-rest-api-route-prefix
@TylerBarnes TylerBarnes requested review from a team and removed request for a team February 2, 2020 23:02
@TylerBarnes
Copy link
Contributor

Ahh, couldn't figure out why I couldn't merge this. @gatsbyjs/learning needs to review since the README was updated, then we should be good. Thanks again @crock 👍

Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for updating the README.

@gatsbybot gatsbybot merged commit 789fb1c into master Feb 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/gatsby-source-wordpress/20995/custom-rest-api-route-prefix branch February 3, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants