fix(gatsby-cli): lower required react version #21522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring latest
react
version ingatsby-cli
(forink
) causes trouble with npm installs - if user specifiedreact
version doesn't satisfy>= 16.8
constraint then it seems likenpm
can't properly resolvenode_modules
hierarchyThis does not take care of #19827 completely, but it limits scenario when this error will happen (with this change it should only happen when user specified version of react is in range
>= 16.3 && < 16.8
(instead of>= 16.3 && 16.12
):16.8.0
version is needed by ink and our ink logger (we use hooks), so can't go lower in this PRCommits where cherry-picked from scratched attempt at fixing it completely ( #21508 )