Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to import * as React from 'react' and remove commonjs interop import #21697

Closed
wardpeet opened this issue Feb 24, 2020 · 2 comments · Fixed by #21700
Closed

Migrate to import * as React from 'react' and remove commonjs interop import #21697

wardpeet opened this issue Feb 24, 2020 · 2 comments · Fixed by #21700
Labels
help wanted Issue with a clear description that the community can help with. type: documentation An issue or pull request for improving or updating Gatsby's documentation type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Comments

@wardpeet
Copy link
Contributor

Description

Reactjs has merged facebook/react#18102 and are moving into es module exports so the correct way of importing react will be import * as React from 'react', they will keep the default exports to keep everything working as expecting.

We should update our documentation and internal code to move to the new import statement.

Expected result

All react imports should be import * as React from 'react'

Actual result

All react imports should be import React from 'react'

More info:

@wardpeet wardpeet added type: documentation An issue or pull request for improving or updating Gatsby's documentation type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change help wanted Issue with a clear description that the community can help with. effort: low labels Feb 24, 2020
@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Mar 15, 2020
@github-actions
Copy link

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.
Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community! 💪💜

@LekoArts LekoArts reopened this Mar 26, 2020
@LekoArts LekoArts removed the stale? Issue that may be closed soon due to the original author not responding any more. label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issue with a clear description that the community can help with. type: documentation An issue or pull request for improving or updating Gatsby's documentation type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants