Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-mdx): add context dependency to mdx-scopes loader #22121

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

csr632
Copy link
Contributor

@csr632 csr632 commented Mar 10, 2020

Description

Otherwise webpack will not rebuild when new scpoes is writed into cache. This can happen if you change mdx file when gatsby develop.

Documentation

Related Issues

@csr632 csr632 requested a review from a team as a code owner March 10, 2020 02:39
csr632 added a commit to aliyun/alibabacloud-console-components that referenced this pull request Mar 10, 2020
@pieh
Copy link
Contributor

pieh commented Mar 11, 2020

How do you trigger webpack not refreshing right now? (how to reproduce problem you are trying to fix)

csr632 added a commit to csr632/reproduce-gatsby-pull-22121 that referenced this pull request Mar 11, 2020
@csr632
Copy link
Contributor Author

csr632 commented Mar 11, 2020

I have made a minimal repo for this bug(based on gatsby-starter-hello-world):

csr632/reproduce-gatsby-pull-22121@b0a19a4

@pieh

@pieh
Copy link
Contributor

pieh commented Mar 12, 2020

Ok, the fix definitely fixes the issue with this reproduction. I do wonder if adding entire scope directory as dependency is correct here and whether it should be more nuanced. Not all scope files will need to be invalidated if any of scope files changes?

I'll tag @johno for his mdx and webpack insights ;)

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, after brief investigation - the mdx-scopes loader is used for "virtual" scopeContexts import and it targets single "file", so I think this is correct and we should "rebuild" that virtual module if anything in scopes directory changes.

Thanks @csr632!

@pieh pieh merged commit f62001e into gatsbyjs:master Mar 12, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 12, 2020

Holy buckets, @csr632 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

WebEngineerLi pushed a commit to WebEngineerLi/console-components that referenced this pull request Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants