fix(gatsby-dev-cli): Include theme src directories #22147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Themes aren't built/compiled like most packages in the gatsby monorepo so we shouldn't ignore their src directories.
johno
force-pushed
the
include-theme-src-files
branch
from
0665272
to
cd95a62
Compare
wardpeet
added
the
bot: merge on green
This was referenced May 16, 2022
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Themes aren't built/compiled like most packages in the gatsby monorepo so we shouldn't ignore their src directories. This now ensures that
gatsby-dev --packages gatsby-theme-blogbehaves as we'd expect.Note: Right now the test is failing because thegatsby/srctest is failing, I'd imagine because we're calling the add event directly which happens after the watchers. So, in all reality then, my tests aren't actually testing anything. Is there some way to test this functionality that I'm missing?Edit: We opted to not test here because it would require digging deeply into the chokidar mocking.