fix gatsby link typescript definition #2224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typescript definition only declared the props that GatsbyLink added, omitting the fact that the props of
NavLink
are available and valid as well.Currently, this leads to typescript errors like
In this case, I wanted to specify a
className
for aGatsbyLink
.By extending the
GatsbyLinkProps
fromNavLinkProps
, Typescript knows that all theNavLinkProps
are available and valid as well.