Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax should now be 'func' #2296

Merged

Conversation

foggy1
Copy link
Contributor

@foggy1 foggy1 commented Oct 1, 2017

The official syntax for requiring PropTypes to be a function is now ".func", as per the prop-types docs.

The gatsby-image example site runs fine, but I was having issues getting my config to be okay with the old ".function" syntax, so moving to the new standard that will work for everyone seems like a good solution.

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit 286fde3

https://deploy-preview-2296--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor

Great, thanks! Yeah, I think I've made this mistake before. func just never seems right.

@KyleAMathews KyleAMathews merged commit 8e271da into gatsbyjs:master Oct 1, 2017
@foggy1 foggy1 deleted the topics/fix-gatsby-image-prop-types branch October 2, 2017 02:59
@jlengstorf
Copy link
Contributor

Hiya @foggy1! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants