use workspaces #2308
use workspaces #2308
Conversation
|
Deploy preview failed. Built with commit 36e2fed https://app.netlify.com/sites/using-glamor/deploys/59d28095a6188f0bce89ea2e |
|
Deploy preview failed. Built with commit 924dd6e https://app.netlify.com/sites/using-glamor/deploys/59d2b689df99532e5cfb1d85 |
|
Deploy preview ready! Built with commit 36e2fed |
|
Deploy preview ready! Built with commit 924dd6e |
| @@ -0,0 +1,12 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
For some reason the .gitignore file isn't ignoring this
| @@ -48,7 +51,7 @@ | |||
| "lint": "npm run check-versions && eslint --ext .js,.jsx --ignore-path .gitignore .", | |||
| "lint:flow": "babel-node scripts/flow-check.js", | |||
| "plop": "plop", | |||
| "bootstrap": "yarn && npm run check-versions && lerna bootstrap", | |||
| "bootstrap": "yarn && npm run check-versions && lerna run prepublish", | |||
There was a problem hiding this comment.
Do we want to run prepublish for bootstrapping? Perhaps this is a problem just with my workflow but I'm always watching the repo to do changes so don't need to compile files as part of bootstrap. Or does prepublish do more than just compile now?
Though probably it makes sense as the default. With workspaces I can just run yarn now to install everything everywhere right?
There was a problem hiding this comment.
It's safe thing to do, and required for tests to pass. The issue is on packages that depend on each other, if gatsby-foo needs gatsby-foo jest isn't going to resolve gatsby-foo to the src directory so the compiled files need to exist. It's not strictly required to get going tho. You can just run yarn and start working and everything will be installed 👍
|
Thanks! |
* use workspaces * Update ignore file
Uses yarn workspaces! gatsby dev now requires yarn ^1.0.2