Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-admin): Setup Gatsby Admin site #23291

Merged
merged 26 commits into from
Apr 24, 2020
Merged

fix(gatsby-admin): Setup Gatsby Admin site #23291

merged 26 commits into from
Apr 24, 2020

Conversation

mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Apr 20, 2020 •
edited

☂️ This is an umbrella PR that smaller PRs get added to! ☂️

This is a first Gatsby site for Gatsby Admin, based on querying the Recipes GraphQL server. PRs that were reviewed & merged into this umbrella PR:

@mxstbr
Copy link
Contributor Author

mxstbr commented Apr 20, 2020

"Stoiber" is a typo. Did you mean "Stolider"?

No TypoCI 🤣

@mxstbr mxstbr marked this pull request as ready for review April 20, 2020 15:23
@mxstbr mxstbr requested a review from a team as a code owner April 20, 2020 15:23
@mxstbr mxstbr changed the title Render list of plugins and themes in admin Render list of plugins and themes in admin app Apr 20, 2020
@mxstbr mxstbr requested a review from a team April 20, 2020 15:24
@laurieontech
Copy link
Contributor

Big thing for me here is a barebones README on how to use/run it. I'd love to test it out and currently don't know how lol

KyleAMathews
KyleAMathews reviewed Apr 20, 2020
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

We should add a CODEOWNERS file like we did for gatsby-recipes.

@mxstbr mxstbr requested a review from a team as a code owner April 21, 2020 06:13
@mxstbr
Copy link
Contributor Author

mxstbr commented Apr 21, 2020

The unit_tests_www test failures are unrelated flakes. I can't view the "Cloud Tests" failures (no permission), but they are likely unrelated as well.

This is ready to be reviewed and merged!

@mxstbr mxstbr mentioned this pull request Apr 21, 2020
Merged
@mxstbr mxstbr requested a review from a team as a code owner April 21, 2020 10:13
laurieontech
laurieontech reviewed Apr 21, 2020
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny edit. I will try and run this a bit later!

packages/gatsby-admin/README.md Outdated Show resolved Hide resolved
KyleAMathews
KyleAMathews previously approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@laurieontech
Copy link
Contributor

Ok, pushed the README changes based on our walkthrough @mxstbr.
I think the best way forward is to make the umbrella PR and merge this and the mutations change into that?

@mxstbr
Copy link
Contributor Author

mxstbr commented Apr 22, 2020

This'll just be the umbrella PR, as it's the base for all of them anyway!

Since all the individual changes (i.e. the other PRs) have been approved, I'm going to get their CI green and merge them into here, and then get this first version into master 👍

@mxstbr mxstbr mentioned this pull request Apr 22, 2020
Closed
@mxstbr mxstbr changed the title Render list of plugins and themes in admin app ☂️ Gatsby Admin site Apr 22, 2020
@mxstbr
Copy link
Contributor Author

mxstbr commented Apr 22, 2020

This is now the Umbrella PR for Gatsby Admin and is ready to go!

I merged both child PRs into here once they were reviewed and approved (#23335 and #23337), and this was also reviewed and approved so it is ready to be merged into master?! 👍

@mxstbr @jxnblk
Update packages/gatsby-admin/README.md
e631939 
Co-Authored-By: Brent Jackson <jxnblk@gmail.com>
@mxstbr mxstbr mentioned this pull request Apr 24, 2020
Closed
LekoArts
LekoArts previously requested changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more request 🙏

packages/gatsby-admin/src/pages/index.tsx Show resolved Hide resolved
freiksenet
freiksenet approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@freiksenet freiksenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as @wardpeet is fine irt publish, we are good to go.

@wardpeet wardpeet changed the title ☂️ Gatsby Admin site fix(gatsby-admin): Setup Gatsby Admin site Apr 24, 2020
@wardpeet wardpeet merged commit 385dfae into master Apr 24, 2020
@wardpeet wardpeet deleted the feat/phpMyAdmin branch April 24, 2020 10:25
@mxstbr mxstbr added this to Done in Gatsby Admin v1 Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxnblk jxnblk jxnblk left review comments

@laurieontech laurieontech laurieontech left review comments

@freiksenet freiksenet freiksenet approved these changes

@KyleAMathews KyleAMathews KyleAMathews left review comments

@LekoArts LekoArts LekoArts left review comments

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Gatsby Admin v1
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mxstbr @laurieontech @KyleAMathews @freiksenet @jxnblk @LekoArts @wardpeet