Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox HMR error in console #23647

Closed
wesbos opened this issue Apr 30, 2020 · 3 comments
Closed

Firefox HMR error in console #23647

wesbos opened this issue Apr 30, 2020 · 3 comments
Labels
stale? Issue that may be closed soon due to the original author not responding any more. status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in Gatsby type: upstream Issues outside of Gatsby's control, caused by dependencies

Comments

@wesbos
Copy link
Contributor

wesbos commented Apr 30, 2020

This isn't breaking anything, but on every single page load, I get this error with either versions of hot reloading turned on:

The connection to http://localhost:8000/__webpack_hmr was interrupted while the page was loading

Followed by [HMR] Connected.

This is in Firefox only and I had the exact same issue in Next.js, which was fixed here:

vercel/next.js#9776

It seems like the fix was adding this:

    window.addEventListener('beforeunload', () => {
      closePing()
    })

https://github.com/zeit/next.js/pull/9798/files

Steps to reproduce

  1. Clone a website - like gatsby starter.
  2. Open in Firefox (I'm using developer edition)
  3. View the console error

Environment

System:
OS: macOS 10.15.2
CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 13.9.0 - /usr/local/bin/node
Yarn: 1.22.0 - /usr/local/bin/yarn
npm: 6.13.7 - /usr/local/bin/npm
Languages:
Python: 2.7.15 - /usr/local/bin/python
Browsers:
Chrome: 81.0.4044.129
Firefox: 59.0.1
Safari: 13.0.4
npmGlobalPackages:
gatsby: 2.15.14

@wesbos wesbos added the type: bug An issue or pull request relating to a bug in Gatsby label Apr 30, 2020
@pieh pieh added the status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. label Apr 30, 2020
@pieh
Copy link
Contributor

pieh commented Apr 30, 2020

Thanks for pointer to Next.js fix, but closePing() is using some of Next.js internals that make use of EventSource. We likely do need similar fix, but we don't use EventSource directly, so this is hidden somewhere in our dependencies. So from initial evaluation this might need fix somewhere upstream - we just need to figure out where :)

@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label May 21, 2020
@danabrit danabrit added type: upstream Issues outside of Gatsby's control, caused by dependencies topic: reach/router and Links labels May 29, 2020
@github-actions
Copy link

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.
Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more. status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in Gatsby type: upstream Issues outside of Gatsby's control, caused by dependencies
Projects
None yet
Development

No branches or pull requests

3 participants