Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding gatsby-plugin-styletron and an example site for it. #2365

Merged
merged 1 commit into from Oct 8, 2017
Merged

Adding gatsby-plugin-styletron and an example site for it. #2365

merged 1 commit into from Oct 8, 2017

Conversation

nadiia
Copy link
Contributor

@nadiia nadiia commented Oct 6, 2017

No description provided.

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Oct 6, 2017 •
edited

Deploy preview failed.

Built with commit 64799cf3fb6d88b90e1e7bc88b1725ff8a1a5099

https://app.netlify.com/sites/using-glamor/deploys/59d809c2df99532fcb86c375

@KyleAMathews
Copy link
Contributor

Looks legit! Thanks for the contribution!

@KyleAMathews KyleAMathews merged commit 6681a96 into gatsbyjs:master Oct 8, 2017
mingaldrichgan
mingaldrichgan reviewed Oct 8, 2017
View reviewed changes
Copy link
Contributor

@mingaldrichgan mingaldrichgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples/using-styletron/src/html.js has two mentions of Glamor that should be updated to say Styletron.

examples/using-styletron/src/html.js

<meta name="referrer" content="origin" />
<meta charSet="utf-8" />
<meta name="description" content="Gatsby example site using Glamor" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be updated to say Styletron instead of Glamor.

examples/using-styletron/src/html.js
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>Gatsby Glamor</title>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

@jlengstorf
Copy link
Contributor

Hiya @nadiia! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingaldrichgan mingaldrichgan mingaldrichgan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nadiia @KyleAMathews @jlengstorf @mingaldrichgan