Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-dev-cli): fix "expected manifest" errors #23871

Merged
merged 3 commits into from
May 7, 2020
Merged

Conversation

pieh
Copy link
Contributor

@pieh pieh commented May 7, 2020

I was checking on one instance of "expected manifest" error and seems like in some cases using dist-tag over concrete version when installing dependencies was triggering this problem (problem in yarn perhaps?). Using concrete versions seems to solve it (at least in reproduction I had).

There are also few QoL improvements:

  • increase request retries for npm registry uplink - on flaky connections (or maybe when npm registry is getting hammered) installation would sometimes fail because of those - this adds bit more resilience
  • don't display those annoying and not actionable "Installation of dependencies after initial scan is not implemented" messages when package.json is being changed by gatsby-dev itself while publishing dev versions of packages
  • in case of yarn installation failures - exit the process and don't continue - this particulary annoying because of output spam when you don't use --quiet you don't actually see that installation failed, and gatsby-dev continued to copy files phase resulting in not installed packages, just copied files in node_modules

You try it by installing qol canary: npm i -g gatsby-dev-cli@qol

@pieh pieh requested a review from a team as a code owner May 7, 2020 15:11
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 7, 2020
@pieh pieh added status: needs core review Currently awaiting review from Core team member and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 7, 2020
@pieh pieh changed the title fix(gatsby-dev-cli): hopefully fix "expected manifest" errors fix(gatsby-dev-cli): fix "expected manifest" errors May 7, 2020
@pieh pieh merged commit a29aca1 into master May 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the gatsby-dev-qol-vol-73 branch May 7, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs core review Currently awaiting review from Core team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants