Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-dev-cli): fix set-path-to-repo command after yargs bump #23899

Merged
merged 1 commit into from
May 8, 2020

Conversation

pieh
Copy link
Contributor

@pieh pieh commented May 8, 2020

We were misusing .nargs function previously but it worked, but recent yargs bump cause it to fail now.

https://github.com/yargs/yargs/blob/master/docs/api.md#nargskey-count

The number of arguments that should be consumed after a key. This can be a useful hint to prevent parsing ambiguity.

set-path-to-repo requires one argument, otherwise it turns into boolean switch

@pieh pieh requested a review from a team as a code owner May 8, 2020 10:12
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 8, 2020
@pvdz pvdz added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 8, 2020
@pieh pieh merged commit b130a8e into master May 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the pieh-patch-2 branch May 8, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants