Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: link to findpath.js is broken #24796

Closed
dandv opened this issue Jun 5, 2020 · 2 comments
Closed

Docs: link to findpath.js is broken #24796

dandv opened this issue Jun 5, 2020 · 2 comments
Assignees
@wardpeet
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation

Comments

@dandv
Copy link
Contributor

dandv commented Jun 5, 2020 •
edited

At https://www.gatsbyjs.org/docs/gatsby-internals-terminology/#matchpath, the link under find-path.js is missing in the source.

But on the frontend, when resolving the page from the path (find-path.js), it is used (via reach router) to find the matching page.

The link to "pages are sorted" in the next paragraph is broken too.

Note that the pages are sorted so that those with matchPaths are at the end, so that explicit paths are matched first.
@dandv dandv added the type: bug An issue or pull request relating to a bug in Gatsby label Jun 5, 2020
@gatsbot gatsbot bot added type: documentation An issue or pull request for improving or updating Gatsby's documentation status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 5, 2020
@freiksenet freiksenet added status: inkteam assigned and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 5, 2020
@muescha
Copy link
Contributor

muescha commented Jun 6, 2020 •
edited by LekoArts

there is a warning at the top of this doc, that this is outdated...

see also #24228

@muescha muescha mentioned this issue Jun 6, 2020
Closed
@LekoArts LekoArts added help wanted Issue with a clear description that the community can help with. status: inkteam assigned and removed status: inkteam assigned type: bug An issue or pull request relating to a bug in Gatsby help wanted Issue with a clear description that the community can help with. labels Jun 8, 2020
@LekoArts
Copy link
Contributor

LekoArts commented Mar 8, 2021

I'll close this in favor of #14228 - with Incremental builds in OSS now in Gatsby v3 some more things have changed

@LekoArts LekoArts closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wardpeet wardpeet

Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dandv @freiksenet @muescha @wardpeet @LekoArts