Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bin): point bin to always existing files #25121

Merged
merged 1 commit into from
Jun 19, 2020
Merged

fix(bin): point bin to always existing files #25121

merged 1 commit into from
Jun 19, 2020

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Jun 19, 2020

Description

Currently we point bin to files that have to be built. That means that first time running yarn will not create actual node_modules/.bin files. This cause problems in CI in some cases - like in https://app.circleci.com/pipelines/github/gatsbyjs/gatsby/43431/workflows/5f2af482-c297-489f-aecf-dbfec72a45b8/jobs/440080/steps where gatsby-admin can't be built because bin for neither gatsby nor gatsby-cli is created yet

@pieh pieh requested a review from a team as a code owner June 19, 2020 13:24
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 19, 2020
@pieh pieh added topic: cli Related to the Gatsby CLI type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change status: needs core review Currently awaiting review from Core team member and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 19, 2020
@sidharthachatterjee sidharthachatterjee removed the status: needs core review Currently awaiting review from Core team member label Jun 19, 2020
sidharthachatterjee
sidharthachatterjee approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this @pieh 🌮

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jun 19, 2020
@gatsbybot gatsbybot merged commit eba033e into master Jun 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/cli-bin/point-to-always-existing-files branch June 19, 2020 17:01
@pieh pieh mentioned this pull request Jun 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: cli Related to the Gatsby CLI type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pieh @sidharthachatterjee @gatsbybot