Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-design-tokens): yarn run watch broken #25369

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

ehrencrona
Copy link
Contributor

@ehrencrona ehrencrona commented Jun 28, 2020

Description

Running yarn run watch on Gatsby is currently broken. This is because microbundle 0.12.2 does not seem to support being passed regexps on the command line anymore; replacing files specified as regexps by a list of time.

Related Issues

Fixes #25368

@ehrencrona ehrencrona requested a review from a team as a code owner June 28, 2020 13:54
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 28, 2020
@ehrencrona ehrencrona changed the title New version of microbundle broke yarn run watch fix(gatsby-design-tokens): new version of microbundle broke yarn run watch Jun 28, 2020
@ehrencrona ehrencrona changed the title fix(gatsby-design-tokens): new version of microbundle broke yarn run watch fix(gatsby-design-tokens): yarn run watch broken Jun 28, 2020
@blainekasten
Copy link
Contributor

I'm personally not running into issues with the current system, but I also validated that this "fix" is safe to do. So we'll go with it :)

@blainekasten blainekasten added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 29, 2020
@gatsbybot gatsbybot merged commit e563a2e into gatsbyjs:master Jun 29, 2020
@fk
Copy link
Contributor

fk commented Jun 29, 2020

🤗 Thank you both!! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm run watch broken on Gatsby master: /^(src$/: Unterminated group
4 participants