Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-design-tokens): Add border definitions to theme #25486

Merged
merged 2 commits into from
Jul 3, 2020

Conversation

tesseralis
Copy link
Contributor

@tesseralis tesseralis commented Jul 2, 2020

Description

Add borders to the design tokens theme so that we can do stuff like #25460.

Screenshot of gatsby homepage with dev tools open showing borders properly applied to the banner link

@tesseralis tesseralis requested a review from fk July 2, 2020 23:04
@tesseralis tesseralis requested a review from a team as a code owner July 2, 2020 23:04
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 2, 2020
@gatsby-cloud-staging
Copy link

Your pull request can be previewed in Gatsby Cloud: https://build-70542ab1-aee2-44a6-b7cb-3851486d2c65.staging-previews.gtsb.io

Copy link
Contributor

@fk fk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh … ay ay ay 🤦
Thank you, thank you, thank you Nat! 🙏

@tesseralis tesseralis added topic: website and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 3, 2020
@tesseralis
Copy link
Contributor Author

I know this says this is under @gatsbyjs/core but I'm gonna merge it in because @fk is pretty much the owner of this package.

@tesseralis tesseralis merged commit 7efdbd3 into master Jul 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the gatsby-design-tokens/borders branch July 3, 2020 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants