Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-admin): add favicon #26121

Merged
merged 1 commit into from
Jul 30, 2020
Merged

feat(gatsby-admin): add favicon #26121

merged 1 commit into from
Jul 30, 2020

Conversation

mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Jul 30, 2020

This copies the favicon from www (gatsbyjs.org) to brand Gatsby Admin a little bit more.

@mxstbr mxstbr requested a review from laurieontech July 30, 2020 05:18
@mxstbr mxstbr requested a review from a team as a code owner July 30, 2020 05:18
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 30, 2020
@mxstbr mxstbr added this to In progress in Gatsby Admin v1 via automation Jul 30, 2020
@mxstbr mxstbr removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 30, 2020
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 30, 2020

Gatsby Cloud Build Report

using-styled-components

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 19s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 💚 90
Best Practices 💚 100
SEO 💚 90

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 30, 2020

Gatsby Cloud Build Report

client-only-paths

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 18s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 🔶 85
Best Practices 💚 100
SEO 🔶 70

🔗 View full report

@gatsby-cloud-staging
Copy link

gatsby-cloud-staging bot commented Jul 30, 2020

Gatsby Cloud Build Report

gatsby-master

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 1m

Performance

Lighthouse report

Metric Score
Performance 💚 96
Accessibility 🔶 87
Best Practices 💚 93
SEO 🔶 73

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 30, 2020

Gatsby Cloud Build Report

using-reach-skip-nav

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 19s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 💚 100
Best Practices 💚 100
SEO 🔶 82

🔗 View full report

@gatsby-cloud-staging
Copy link

Gatsby Cloud Build Report

gatsby

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 17m

Performance

Lighthouse report

Metric Score
Performance 💚 94
Accessibility 💚 100
Best Practices 💚 100
SEO 🔶 76

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 30, 2020

Gatsby Cloud Build Report

gatsby

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 19m

Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@laurieontech laurieontech merged commit 0211c05 into master Jul 30, 2020
Gatsby Admin v1 automation moved this from In progress to Done Jul 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the admin/favicon branch July 30, 2020 11:53
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants