Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-admin): add modal to manage plugin #26154

Merged
merged 6 commits into from
Jul 31, 2020
Merged

feat(gatsby-admin): add modal to manage plugin #26154

merged 6 commits into from
Jul 31, 2020

Conversation

mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Jul 31, 2020

This is what it looks like for now:

Screenshot 2020-07-31 at 08 16 25

Screenshot 2020-07-31 at 08 16 40

Closes #26126, [ch12760]

@mxstbr mxstbr requested a review from laurieontech July 31, 2020 06:19
@mxstbr mxstbr requested a review from a team as a code owner July 31, 2020 06:19
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 31, 2020
@mxstbr mxstbr added this to In progress in Gatsby Admin v1 via automation Jul 31, 2020
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 31, 2020 •
edited

Gatsby Cloud Build Report

client-only-paths

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 19s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 🔶 85
Best Practices 💚 100
SEO 🔶 70

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 31, 2020 •
edited

Gatsby Cloud Build Report

using-styled-components

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 21s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 💚 90
Best Practices 💚 100
SEO 💚 90

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 31, 2020 •
edited

Gatsby Cloud Build Report

using-reach-skip-nav

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 20s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 💚 100
Best Practices 💚 100
SEO 🔶 82

🔗 View full report

@mxstbr mxstbr removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 31, 2020
@gatsby-cloud-staging
Copy link

gatsby-cloud-staging bot commented Jul 31, 2020 •
edited

Gatsby Cloud Build Report

gatsby-master

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 1m

Performance

Lighthouse report

Metric Score
Performance 💚 97
Accessibility 🔶 87
Best Practices 💚 93
SEO 🔶 73

🔗 View full report

@gatsby-cloud-staging
Copy link

gatsby-cloud-staging bot commented Jul 31, 2020 •
edited

Gatsby Cloud Build Report

gatsby

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 19m

Performance

Lighthouse report

Metric Score
Performance 💚 93
Accessibility 💚 100
Best Practices 💚 100
SEO 🔶 76

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 31, 2020 •
edited

Gatsby Cloud Build Report

gatsby

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 18m

laurieontech
laurieontech previously approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for picking up where I left off.

laurieontech
laurieontech approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay errors!

@mxstbr mxstbr merged commit c1110b3 into master Jul 31, 2020
Gatsby Admin v1 automation moved this from In progress to Done Jul 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the admin-input-form branch July 31, 2020 13:37
KyleAMathews added a commit that referenced this pull request Jul 31, 2020
@KyleAMathews
Squashed commit of the following:
a71b9b8 
commit 5791f9e
Author: Joshua Comeau <joshwcomeau@gmail.com>
Date:   Fri Jul 31 11:32:59 2020 -0400

    write new blog post about Will It Build (#26113)

    * write new blog post about Will It Build

    * Update date

    * Update date on the post as well

    * fix images

    * re-add post o_O

    * Fix WordPress spelling

commit feedd1f
Author: Max Stoiber <contact@mxstbr.com>
Date:   Fri Jul 31 16:56:16 2020 +0200

    chore(release): Publish

     - gatsby-admin@0.1.110
     - gatsby@2.24.21

commit 2f61ef9
Author: Max Stoiber <contact@mxstbr.com>
Date:   Fri Jul 31 16:49:34 2020 +0200

    chore(release): Publish

     - gatsby-admin@0.1.109
     - gatsby@2.24.20

commit 157bf79
Author: Max Stoiber <contact@mxstbr.com>
Date:   Fri Jul 31 16:45:06 2020 +0200

    chore(release): Publish

     - gatsby-admin@0.1.108
     - gatsby@2.24.19

commit 471cb04
Author: Max Stoiber <contact@mxstbr.com>
Date:   Fri Jul 31 16:41:35 2020 +0200

    chore(release): Publish

     - gatsby-admin@0.1.107
     - gatsby@2.24.18

commit 23e6e9b
Author: Max Stoiber <contact@mxstbr.com>
Date:   Fri Jul 31 16:39:01 2020 +0200

    chore(release): Publish

     - gatsby-admin@0.1.106
     - gatsby@2.24.17

commit e9c1f81
Author: Max Stoiber <contact@mxstbr.com>
Date:   Fri Jul 31 16:34:23 2020 +0200

    chore(release): Publish

     - gatsby-admin@0.1.105
     - gatsby-plugin-mdx@1.2.31
     - gatsby@2.24.16

commit 1c5d8e9
Author: Max Stoiber <contact@mxstbr.com>
Date:   Fri Jul 31 16:23:32 2020 +0200

    feat(gatsby-admin): new navbar design (#26159)

    * feat(gatsby-admin): new navbar design

    * Update yarn.lock

    * graphiql

commit c1110b3
Author: Max Stoiber <contact@mxstbr.com>
Date:   Fri Jul 31 15:37:27 2020 +0200

    feat(gatsby-admin): add modal to manage plugin (#26154)

    * very rough, includes initial query

    * very rough, includes initial query

    * feat(gatsby-admin): add modal to manage plugin

    * Add loading states

    * Delete unused file

    * Show errors in UI

    Co-authored-by: Laurie Barth <laurie@LauriesrkLaptop.fios-router.home>

commit a86658e
Author: Muescha <184316+muescha@users.noreply.github.com>
Date:   Fri Jul 31 10:02:44 2020 +0200

    fix(blog): i18n themes - link to discord, indentions in diff, filename in code fences (#26103)

commit 32c3e8e
Author: Marcy Sutton <marcy@gatsbyjs.com>
Date:   Fri Jul 31 00:56:13 2020 -0700

    fix: headings in plugin authoring study post failing linter (#26150)

commit e001e11
Author: Kyle Mathews <mathews.kyle@gmail.com>
Date:   Thu Jul 30 15:53:35 2020 -0700

    Update index.md

commit 613589e
Author: Megan Sullivan <meganesulli@gmail.com>
Date:   Thu Jul 30 13:44:17 2020 -0700

    [docs][guides] other css frameworks (#26087)

    * docs: first draft of Other CSS Frameworks guide

    * feat: add Other CSS Frameworks guide to docs sidebar

    * docs: complete initial draft of Other CSS Frameworks guide

    * edit: reorder Grommet resources

    * chore: lint fix

    * edit: simplify using Hemingway; adhere to style guide

    * edit: remove extra quotes for inline code examples

    Co-authored-by: Aisha Blake <aisha.g.blake@gmail.com>

    * edit: remove unneeded link query param

    Co-authored-by: Aisha Blake <aisha.g.blake@gmail.com>

    * edit: reword jQuery sentence

    Co-authored-by: Aisha Blake <aisha.g.blake@gmail.com>

    * edit: convert list of criteria to guidelines on choosing a framework

    * edit: update list of considerations for choosing a framework

    * fix: make gatsbyjs.org url relative

    * edit: clarify use of 'theme' in chakra ui explanation

    * edit: use consistent note structure

    Co-authored-by: Aisha Blake <aisha.g.blake@gmail.com>

    Co-authored-by: Aisha Blake <aisha.g.blake@gmail.com>
resource11 pushed a commit to resource11/gatsby that referenced this pull request Aug 1, 2020
@mxstbr @resource11
feat(gatsby-admin): add modal to manage plugin (gatsbyjs#26154)
3d7f3e0 
* very rough, includes initial query

* very rough, includes initial query

* feat(gatsby-admin): add modal to manage plugin

* Add loading states

* Delete unused file

* Show errors in UI

Co-authored-by: Laurie Barth <laurie@LauriesrkLaptop.fios-router.home>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurieontech laurieontech laurieontech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Gatsby Admin v1
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement editing plugin options as JSON
2 participants
@mxstbr @laurieontech