Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-admin): new navbar design #26159

Merged
merged 4 commits into from
Jul 31, 2020
Merged

feat(gatsby-admin): new navbar design #26159

merged 4 commits into from
Jul 31, 2020

Conversation

mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Jul 31, 2020 •
edited

Screenshot 2020-07-31 at 09 26 27

Notes:

  • I changed the wording of "Need help?" to "Send feedback" as we don't have any authentication and thus can't reply to people.
  • I have no idea how we're going to show the favicon. If folks have png (or even svg) favicons they could be at any location, we'd have to fetch the index.html and then parse the HTML for the <link rel="icon" /> or something? 馃槙

[ch12797]
Closes #26129

@mxstbr mxstbr requested a review from laurieontech July 31, 2020 07:29
@mxstbr mxstbr requested review from a team as code owners July 31, 2020 07:29
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 31, 2020
@mxstbr mxstbr added this to In progress in Gatsby Admin v1 via automation Jul 31, 2020
@mxstbr mxstbr removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 31, 2020
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 31, 2020 •
edited

Gatsby Cloud Build Report

client-only-paths

馃帀 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

馃晲 Build time: 1m

Performance

Lighthouse report

Metric Score
Performance 馃挌 100
Accessibility 馃敹 85
Best Practices 馃挌 100
SEO 馃敹 70

馃敆 View full report

@gatsby-cloud-staging
Copy link

gatsby-cloud-staging bot commented Jul 31, 2020 •
edited

Gatsby Cloud Build Report

gatsby-master

馃帀 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

馃晲 Build time: 1m

Performance

Lighthouse report

Metric Score
Performance 馃挌 98
Accessibility 馃敹 87
Best Practices 馃挌 93
SEO 馃敹 73

馃敆 View full report

@mxstbr
Copy link
Contributor Author

mxstbr commented Jul 31, 2020

Lint error is in a blogpost that was not edited in this PR, same error exists in master.

LekoArts
LekoArts reviewed Jul 31, 2020
View reviewed changes
packages/gatsby-admin/src/components/navbar.tsx Outdated
>
Visit site
</BaseAnchor>
GraphQL&nbsp;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe even say GraphiQL ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, I'd agree with this. Probably a conversation for design, but we do use this term in the docs and it would be good to stay consistent.

@gatsby-cloud

This comment has been minimized.

Sign in to view
laurieontech
laurieontech approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Nice work!

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 31, 2020 •
edited

Gatsby Cloud Build Report

using-styled-components

馃帀 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

馃晲 Build time: 18s

Performance

Lighthouse report

Metric Score
Performance 馃挌 100
Accessibility 馃挌 90
Best Practices 馃挌 100
SEO 馃挌 90

馃敆 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 31, 2020 •
edited

Gatsby Cloud Build Report

using-reach-skip-nav

馃帀 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

馃晲 Build time: 21s

Performance

Lighthouse report

Metric Score
Performance 馃挌 100
Accessibility 馃挌 100
Best Practices 馃挌 100
SEO 馃敹 82

馃敆 View full report

@gatsby-cloud-staging
Copy link

gatsby-cloud-staging bot commented Jul 31, 2020 •
edited

Gatsby Cloud Build Report

gatsby

馃帀 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

馃晲 Build time: 23m

Performance

Lighthouse report

Metric Score
Performance 馃挌 93
Accessibility 馃挌 100
Best Practices 馃挌 100
SEO 馃敹 76

馃敆 View full report

@mxstbr mxstbr merged commit 1c5d8e9 into master Jul 31, 2020
Gatsby Admin v1 automation moved this from In progress to Done Jul 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the admin/navbar branch July 31, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts left review comments

@laurieontech laurieontech laurieontech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Gatsby Admin v1
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align navbar styling with new design
3 participants
@mxstbr @laurieontech @LekoArts