fix(structured-logging): fix wrongly reporting status as success when we should still be in pending state #26380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: reporter
and removed
status: triage needed
Gatsby Cloud Build Reportclient-only-paths 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 18s PerformanceLighthouse report
|
Gatsby Cloud Build Reportusing-styled-components 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 18s PerformanceLighthouse report
|
Gatsby Cloud Build Reportgatsby-master 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 1m PerformanceLighthouse report
|
pieh
force-pushed
the
fix/structured-logging/fix-delayed-set-status
branch
from
c0e53d2
to
0a6c431
Compare
Gatsby Cloud Build Reportusing-reach-skip-nav 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 22s PerformanceLighthouse report
|
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 22m PerformanceLighthouse report
|
pieh
force-pushed
the
fix/structured-logging/fix-delayed-set-status
branch
from
0a6c431
to
ecedcb6
Compare
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 23m |
…ET_STATUS dispatch
pieh
changed the title
pieh
commented
Aug 12, 2020
Comment on lines
-138
to
+166
| const actionsToEmit: ActionsToEmit = [] | ||
|
|
||
| const logsState = getStore().getState().logs | ||
|
|
||
| const globalStatus = getGlobalStatus(id, status) | ||
|
|
||
| if (globalStatus !== logsState.status) { | ||
| actionsToEmit.push(setStatus(globalStatus)) | ||
| } | ||
|
|
||
| actionsToEmit.push({ | ||
| type: Actions.PendingActivity, | ||
| payload: { | ||
| id, | ||
| type: ActivityTypes.Pending, | ||
| status, | ||
| return [ | ||
| setStatus(globalStatus), | ||
| { | ||
| type: Actions.PendingActivity, | ||
| payload: { | ||
| id, | ||
| type: ActivityTypes.Pending, | ||
| status, | ||
| }, | ||
| }, | ||
| }) | ||
|
|
||
| return actionsToEmit | ||
| ] |
There was a problem hiding this comment.
gist of this and other activity related code changes is that we always would use setStatus action creator as it internally already checks for global status (or pending global status for delayed dispatchs)
pvdz
approved these changes
Aug 12, 2020
sidharthachatterjee
approved these changes
Aug 12, 2020
sidharthachatterjee
deleted the
fix/structured-logging/fix-delayed-set-status
branch
|
Successfully published:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
setStatusaction creator calls are not working correctly right now. This PR aims to add bunch of tests first (some of which will fail), and add code changes showing that hose fixes some problems later.