Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-image): do not render the source tag if no srcSet is provided #26766

Merged
merged 1 commit into from
Sep 3, 2020
Merged

fix(gatsby-image): do not render the source tag if no srcSet is provided #26766

merged 1 commit into from
Sep 3, 2020

Conversation

anasbouzid
Copy link
Contributor

According to the spec, a source tag without the srcset attribute is invalid, this small PR makes sure the tag is not rendered in this case.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 2, 2020
@pieh pieh added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 3, 2020
@wardpeet wardpeet changed the title fix(gatsby-image) do not render the source tag if no srcSet is provided fix(gatsby-image): do not render the source tag if no srcSet is provided Sep 3, 2020
wardpeet
wardpeet approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me.

@wardpeet wardpeet merged commit 268d982 into gatsbyjs:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anasbouzid @wardpeet @pieh