feat(gatsby): start telemetry server on gatsby develop for Admin #26853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
mxstbr
added
topic: cli
|
As #26832 hasn't been merged it would probably be easier to review these as a single PR |
|
This is failing pnp tests because you're using "body-parser" without delcaring it as a dependency. |
delete-merged-branch
bot
deleted the
admin/develop-telemetry-service
branch
mxstbr
added a commit
that referenced
this pull request
Sep 14, 2020
* Set up first service exposing gatsby-telemetry * Run background updates * Move telemetry server to gatsby package * Add body-parser dependency * Start telemetry server on gatsby develop (#26853) * Revert "Start telemetry server on gatsby develop (#26853)" This reverts commit 5febd35. * Revert "Revert "Start telemetry server on gatsby develop (#26853)"" This reverts commit 08bb027. * Track first telemetry from Admin * Update telemetry-server.ts
1 task
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
* Set up first service exposing gatsby-telemetry * Run background updates * Move telemetry server to gatsby package * Add body-parser dependency * Start telemetry server on gatsby develop (gatsbyjs#26853) * Revert "Start telemetry server on gatsby develop (gatsbyjs#26853)" This reverts commit 5febd35. * Revert "Revert "Start telemetry server on gatsby develop (gatsbyjs#26853)"" This reverts commit 08bb027. * Track first telemetry from Admin * Update telemetry-server.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we noticed in #26627, gatsby-telemetry can only run in a node context. In order to add telemetry to Admin we created a HTTP server that exposes the telemetry methods for Admin to POST to in #26832.
This PR starts said telemetry server on
gatsby developand stores it as a service for Admin to discover.