feat(gatsby-admin): track plugin telemetry #26885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
jamo
reviewed
Sep 14, 2020
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 21m |
LekoArts
removed
the
status: triage needed
muescha
reviewed
Sep 23, 2020
Comment on lines
+6
to
+7
| test: true, | ||
| bla: false, |
There was a problem hiding this comment.
bla is removed in #26916
but i don't see if the test option used? is this a test leftover?
There was a problem hiding this comment.
Yea, this is just me playing around with configuring plugins in Admin!
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
* Set up first service exposing gatsby-telemetry * Run background updates * Move telemetry server to gatsby package * Add body-parser dependency * Start telemetry server on gatsby develop (gatsbyjs#26853) * Revert "Start telemetry server on gatsby develop (gatsbyjs#26853)" This reverts commit 5febd35. * Revert "Revert "Start telemetry server on gatsby develop (gatsbyjs#26853)"" This reverts commit 08bb027. * Track first telemetry from Admin * Update telemetry-server.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #26832, this fetches the telemetryserver port from the
/___servicesendpoint and adds auseTelemetryhook to Admin that currently has this API (modeled aftergatsby-telemetry):@jamo I'm not 100% sure whether the events I'm currently tracking are inline with what you'd expect us to track! Do the shapes/metadata/etc look alright?