feat(gatsby-source-filesystem): env flag to placeholder remote assets #27663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eholder for remote asset
gatsbot
bot
added
the
status: triage needed
pvdz
added
topic: dev tooling
and removed
status: triage needed
wardpeet
reviewed
Oct 27, 2020
Considered that but I didn't really want to rely on a certain file to be present for this case and I didn't want to inline a base64 image either. I'll split it up |
|
Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page. Generated by 🚫 dangerJS |
pvdz
commented
Oct 29, 2020
wardpeet
approved these changes
Nov 9, 2020
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this pull request
Apr 20, 2023
…gatsbyjs#27663) * feat(gatsby-source-filesystem): add experimental env flag to use placeholder for remote asset * Split up placeholder from remote * reduce patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental env flag to help with debugging. It replaces any remote asset that is fetched through
createRemoteFileNodewith a local placeholder file. The path is used as is.This helps with debugging and profiling sites where the remote assets are not necessary but still take minutes to download. Not meant to be used with regular sites so it's only exposed as an experimental flag.