test(gatsby-plugin-image): gatsby-image-server.ts #27989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
mfrachet
commented
Nov 12, 2020
packages/gatsby-plugin-image/src/components/gatsby-image.server.tsx
Outdated
Show resolved
Hide resolved
mfrachet
added
topic: plugins
|
This looks reasonable to me. It duplicates some of the static image stuff but I think that's fine. |
gillkyle
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add basic tests for gatsby-image-server.ts. The following verifications have been made:
Feel free to request more component level tests.
NB: I will also write Cypress tests when this one gets merged to verify older browser behaviours