Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-gatsby): Disable emojis on Windows #28039

Merged
merged 2 commits into from
Nov 13, 2020
Merged

fix(create-gatsby): Disable emojis on Windows #28039

merged 2 commits into from
Nov 13, 2020

Conversation

ascorbic
Copy link
Contributor

Disables emojis on Windows, because they mostly don't work

[ch18833]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 13, 2020
@laurieontech laurieontech added topic: cli Related to the Gatsby CLI and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 13, 2020
laurieontech
laurieontech approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Did this appear to fix the other weirdness with the install messages?

@ascorbic
Copy link
Contributor Author

It did not, but I'm still working on that

@ascorbic ascorbic merged commit 5fbda3c into master Nov 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/windows-no-emoji branch November 13, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurieontech laurieontech laurieontech approved these changes

Assignees
No one assigned
Labels
topic: cli Related to the Gatsby CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ascorbic @laurieontech