test(gatsby-plugin-image): add test for gatsby-plugin-image browser #28101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
mfrachet
added
topic: media
gillkyle
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
Since me and @mfrachet pulled up this code together and walked through the logic in gatsby-image.browser.tsx and these tests side by side I'm inclined to say this looks good! I learned a thing or two about some testing utilities along the way too 馃檪
| } | ||
|
|
||
| beforeHydrationContent = document.createElement(`div`) | ||
| beforeHydrationContent.innerHTML = ` |
There was a problem hiding this comment.
Woah, is this to replicate the SSR? Clever.
|
Happy it increases confidence! Thanks for the kind words 馃槉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added some tests for gatsby-image.browser
I did what I had in mind, this was quite tough to tests 馃槄
Feel free to ask for more, I'm maybe missing some cases 馃槵