fix(gatsby-dev-cli): Correctly catch 404s from NPM when a package hasn't been published yet #28297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n't been published yet
gatsbot
bot
added
the
status: triage needed
pieh
reviewed
Nov 25, 2020
Comment on lines
64
to
70
| got(`https://unpkg.com/${packageName}/package.json`) | ||
| .then((error, response) => { | ||
| if (response && response.statusCode === 200) { | ||
| return resolve(JSON.parse(response.body)) | ||
| resolve(JSON.parse(response.body)) | ||
| } | ||
|
|
||
| return reject(error) | ||
| } | ||
| ) | ||
| }) | ||
| .catch(e => reject(e)) |
There was a problem hiding this comment.
.then handler can only have single argument - so this should be:
got(`https://unpkg.com/${packageName}/package.json`)
.then(response => {
if (response && response.statusCode === 200) {
return resolve(JSON.parse(response.body))
}
return reject(new Error(`No response or non 200 code`))
})
.catch(e => reject(e))
Seems like migration in #26653 was never actually tested?
There was a problem hiding this comment.
Considering this is inside an async function the whole new Promise expression should be replaced with something like
const response = await got(`https://unpkg.com/${packageName}/package.json`)
if (response?.statusCode !== 200) {
throw new Error(`No response or non 200 code`)
}
localPKGjson = JSON.parse(response.body)There was a problem hiding this comment.
(unless got does not return a proper promise-like?)
There was a problem hiding this comment.
Ah, yeah, you are probably right and await will simplify things - I mostly zoomed in on double args for .then :)
There was a problem hiding this comment.
Seems like migration in #26653 was never actually tested?
Yeah — this isn't a common scenario.
Will change to await 👍
Co-authored-by: Peter van der Zee <209817+pvdz@users.noreply.github.com>
LekoArts
added
topic: dev tooling
and removed
status: triage needed
pieh
added
the
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't use gatsby-dev-cli with new package otherwise