Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): wrong assert method for plugin-image #28319

Merged
merged 2 commits into from
Nov 27, 2020
Merged

Conversation

mfrachet
Copy link
Contributor

Using mocha assertions instead of jest ones in Cypress tests 🤦🏻

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 27, 2020
@mfrachet mfrachet removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 27, 2020
@mfrachet mfrachet added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed bot: merge on green Gatsbot will merge these PRs automatically when all tests passes labels Nov 27, 2020
@mfrachet mfrachet merged commit 2b8fe12 into master Nov 27, 2020
@mfrachet mfrachet deleted the mfrachet/fix-e2e-tests branch November 27, 2020 13:37
pieh pushed a commit that referenced this pull request Dec 7, 2020
pieh pushed a commit that referenced this pull request Dec 7, 2020
…obs (#28314) (#28487)

* test(gatsby-plugin-image): add E2E tests for native and intersection obs (#28314)

* test(gatsby-plugin-image): add E2E tests for native and intersection obs #28314

* fix

* review comments

* review comments

(cherry picked from commit c1cdf51)

* fix(test): wrong assert method for plugin-image (#28319)

(cherry picked from commit 2b8fe12)

Co-authored-by: Marvin Frachet <marvin@gatsbyjs.com>
@pieh pieh added this to To cherry-pick in V2 Release hotfixes via automation Dec 7, 2020
@pieh pieh moved this from To cherry-pick to Backported in V2 Release hotfixes Dec 7, 2020
@pieh pieh moved this from Backported to Archived in V2 Release hotfixes Dec 9, 2020
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants