feat(gatsby-plugin-image): Add helper function to grab src #28463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
laurieontech
added
the
topic: media
LekoArts
removed
the
status: triage needed
laurieontech
commented
Dec 3, 2020
|
Might be worth noting (or changing) the fact that if the only format is webp, there is no src just a srcset. As there is no browser that supports webp but not picture elements, we don't bother with the fallback for them. |
ascorbic
changed the title
|
Hmm, is there a scenario where we only produce webp? I thought that was always extra. |
|
If they specify |
added 2 commits
December 3, 2020 12:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path to get the src of an image is quite long. Adding a helper function makes this a better DX.