Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Back out resolutions, and add ignore-engines to dev cli #28464

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Dec 3, 2020

Revert #28459, as it was breaking gatsby-source-graphql. Instead add the --ignore-engines flag to the dev cli so that e2e tests can at least run

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 3, 2020
@ascorbic ascorbic added topic: dev tooling and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 3, 2020
vladar
vladar previously approved these changes Dec 3, 2020
@ascorbic ascorbic added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 3, 2020
@ascorbic ascorbic merged commit 4add7d2 into master Dec 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/handle-engines branch December 3, 2020 16:05
@vladar vladar added this to To cherry-pick in V2 Release hotfixes via automation Dec 4, 2020
pieh pushed a commit that referenced this pull request Dec 4, 2020
* fix: Back out resolutions, and add ignore-engines to dev cli

* Use dev-cli@next

(cherry picked from commit 4add7d2)
pieh added a commit that referenced this pull request Dec 4, 2020
* fix(gatsby-source-graphql): Pin resolution of extract-files (#28459)

(cherry picked from commit 4ef4bf5)

* fix: Back out resolutions, and add ignore-engines to dev cli (#28464)

* fix: Back out resolutions, and add ignore-engines to dev cli

* Use dev-cli@next

(cherry picked from commit 4add7d2)

Co-authored-by: Matt Kane <matt@gatsbyjs.com>
@pieh pieh moved this from To cherry-pick to Backported in V2 Release hotfixes Dec 4, 2020
@pieh pieh moved this from Backported to Archived in V2 Release hotfixes Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants