Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): Avoid undefined object errors #28554

Merged
merged 2 commits into from
Dec 9, 2020
Merged

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Dec 9, 2020

Compilation was failing in e2e tests because babel was failing when trying to extract queries from a compiled JS bundle. This adds some optional chains to avoid checking for propererties of undefined objects

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 9, 2020
pvdz
pvdz previously approved these changes Dec 9, 2020
@pvdz pvdz added type: bug An issue or pull request relating to a bug in Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 9, 2020
@ascorbic ascorbic merged commit 39995ae into master Dec 9, 2020
@ascorbic ascorbic deleted the fix/file-parser-null-check branch December 9, 2020 13:19
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
* fix(gatsby): Null check for file parser

* Never heard of optional chaining, eslint?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants