Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-image): Add remote image support #28647

Merged
merged 8 commits into from
Dec 18, 2020
Merged

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Dec 16, 2020

Adds initial remote image support to StaticImage. To enable, pass GATSBY_EXPERIMENTAL_REMOTE_IMAGES

API:

      <StaticImage src="https://placekitten.com/400/400" alt="Kittin" />

That's it!

Well that was easier than expected!
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 16, 2020
@ascorbic ascorbic added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 16, 2020
mxstbr
mxstbr previously approved these changes Dec 16, 2020
Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THIS IS FREAKING AMAZING!!!!!!!!!!!!

@ascorbic ascorbic marked this pull request as ready for review December 17, 2020 06:30
@ascorbic ascorbic requested a review from mxstbr December 17, 2020 06:32
@mxstbr
Copy link
Contributor

mxstbr commented Dec 17, 2020

You probably want to use the new flagging system instead of env vars maybe? Although, does that work outside of core? #28296

@ascorbic
Copy link
Contributor Author

I've avoided the flag because it's not something we want people to be offered, as it only makes sense if they have the plugin

@ascorbic ascorbic merged commit a91825d into master Dec 18, 2020
@ascorbic ascorbic deleted the feat/remote-images branch December 18, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants