perf(gatsby-plugin-image): Handle disabled js, and add preload link #28669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
reviewed
Dec 17, 2020
wardpeet
added
topic: media
Co-authored-by: Ward Peeters <ward@coding-tech.com>
wardpeet
approved these changes
Dec 17, 2020
ascorbic
added
the
bot: merge on green
| return ( | ||
| <> | ||
| {props.loading === `eager` && ( | ||
| <link |
There was a problem hiding this comment.
does this actually speed things up? preload helps by a) upping the loading priority within the browser and b) letting the browser discover the resource earlier than it would otherwise.
Since images are already loaded at the highest priority & this is rendered right before the image — it wouldn't change much perhaps?
Might be wrong somewhere in there. But curious if you tested and saw a diff?
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…atsbyjs#28669) * perf(gatsby-plugin-image): Handle disabled js, and add preload link * Update packages/gatsby-plugin-image/src/components/main-image.tsx Co-authored-by: Ward Peeters <ward@coding-tech.com> Co-authored-by: Ward Peeters <ward@coding-tech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows an image if JS is disabled. Adds a preload link for loading=eager images.