Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-sharp): PathPrefix isn't being passed/set for GatsbyImage #28845

Merged
merged 7 commits into from
Jan 5, 2021
Merged

fix(gatsby-plugin-sharp): PathPrefix isn't being passed/set for GatsbyImage #28845

merged 7 commits into from
Jan 5, 2021

Conversation

laurieontech
Copy link
Contributor

@laurieontech laurieontech commented Jan 4, 2021 •
edited
Loading

This is working fine for StaticImage, but GatsbyImage was passing pathPrefix from the wrong place in the resolver and not including it in srcSet for webp and avif images.

[ch20512]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 4, 2021
@laurieontech laurieontech added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 4, 2021
ascorbic
ascorbic approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff

@laurieontech laurieontech merged commit 5874414 into master Jan 5, 2021
@laurieontech laurieontech deleted the fix/gatsby-image-path-prefix branch January 5, 2021 16:19
@laurieontech laurieontech added this to To cherry-pick in V2 Release hotfixes via automation Jan 8, 2021
@gatsbybot gatsbybot mentioned this pull request Jan 12, 2021
Merged
vladar pushed a commit that referenced this pull request Jan 12, 2021
@vladar
fix(gatsby-plugin-sharp): PathPrefix isn't being passed/set for Gatsb…
4150558 
…yImage (#28845)

* fix for path-prefix in GatsbyImage

* add e2e test for path prefix cases

* update tests

* forgot to save

* refactor

* add curlys

(cherry picked from commit 5874414)
@vladar vladar moved this from To cherry-pick to Backport PR opened in V2 Release hotfixes Jan 12, 2021
@vladar vladar added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed bot: merge on green Gatsbot will merge these PRs automatically when all tests passes labels Jan 13, 2021
gatsbybot pushed a commit that referenced this pull request Jan 13, 2021
fix(gatsby-plugin-sharp): PathPrefix isn't being passed/set for Gatsb…
c762050 
…yImage (#28845) (#28991)

* fix for path-prefix in GatsbyImage

* add e2e test for path prefix cases

* update tests

* forgot to save

* refactor

* add curlys

(cherry picked from commit 5874414)

Co-authored-by: LB <laurie@gatsbyjs.com>
@vladar vladar moved this from Backport PR opened to Backported in V2 Release hotfixes Jan 13, 2021
@vladar
Copy link
Contributor

vladar commented Jan 13, 2021

Published in gatsby-plugin-sharp@2.12.1

@vladar vladar moved this from Backported to Archived in V2 Release hotfixes Jan 16, 2021
This was referenced Mar 9, 2021
Closed
Merged
Open
This was referenced Mar 14, 2021
Open
Merged
Merged
Closed
Open
Closed
Closed
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@ViCo0TeCH
fix(gatsby-plugin-sharp): PathPrefix isn't being passed/set for Gatsb…
8c80310 
…yImage (gatsbyjs#28845)

* fix for path-prefix in GatsbyImage

* add e2e test for path prefix cases

* update tests

* forgot to save

* refactor

* add curlys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic approved these changes

Assignees
No one assigned
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
No open projects
V2 Release hotfixes
Archived
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@laurieontech @vladar @ascorbic