Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby,gatsby-admin): Pin socket.io version to 2.3.0 #28885

Merged
merged 1 commit into from
Jan 6, 2021
Merged

fix(gatsby,gatsby-admin): Pin socket.io version to 2.3.0 #28885

merged 1 commit into from
Jan 6, 2021

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Jan 6, 2021

Description

Fixes #28877 as otherwise a breaking change would be pulled in.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 6, 2021
@LekoArts LekoArts changed the title pin socket.io dep fix(gatsby,gatsby-admin): Pin socket.io version to 2.3.0 Jan 6, 2021
@LekoArts LekoArts added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 6, 2021
@LekoArts LekoArts added this to To cherry-pick in V2 Release hotfixes via automation Jan 6, 2021
@LekoArts LekoArts mentioned this pull request Jan 6, 2021
Merged
@LekoArts LekoArts merged commit 247b1dc into master Jan 6, 2021
@LekoArts LekoArts deleted the fix-socket-io branch January 6, 2021 09:46
@gatsbybot gatsbybot mentioned this pull request Jan 6, 2021
Merged
vladar pushed a commit that referenced this pull request Jan 6, 2021
@LekoArts @vladar
fix(gatsby,gatsby-admin): Pin socket.io version to 2.3.0 (#28885)
c4d9fef 
(cherry picked from commit 247b1dc)
gatsbybot pushed a commit that referenced this pull request Jan 6, 2021
@LekoArts
fix(gatsby,gatsby-admin): Pin socket.io version to 2.3.0 (#28885) (#2…
64f2e95 
…8886)

(cherry picked from commit 247b1dc)

Co-authored-by: Lennart <lekoarts@gmail.com>
@vladar
Copy link
Contributor

vladar commented Jan 6, 2021

Published in gatsby@2.30.1

@vladar vladar moved this from To cherry-pick to Backported in V2 Release hotfixes Jan 6, 2021
@LekoArts LekoArts mentioned this pull request Jan 6, 2021
Closed
@vladar vladar moved this from Backported to Archived in V2 Release hotfixes Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvdz pvdz pvdz approved these changes

Assignees
No one assigned
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
No open projects
V2 Release hotfixes
Archived
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Cors error" after updating dependencies
3 participants
@LekoArts @vladar @pvdz