feat: Add support for aspectRatio #28941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
laurieontech
added
topic: media
ascorbic
reviewed
Jan 9, 2021
There was a problem hiding this comment.
I think this needs to handle setting width when only height is passed too. I documented how I think it should work here: in my latest PR
Co-authored-by: Matt Kane <matt@gatsbyjs.com>
ascorbic
reviewed
Jan 11, 2021
ascorbic
reviewed
Jan 11, 2021
Co-authored-by: Matt Kane <matt@gatsbyjs.com>
…/gatsby into feat/image-aspect-ratio
ascorbic
approved these changes
Jan 11, 2021
This was referenced Mar 9, 2021
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
* Add support for aspectRatio * Update packages/gatsby-plugin-sharp/src/image-data.ts Co-authored-by: Matt Kane <matt@gatsbyjs.com> * handle width too, refactor accordingly * Update packages/gatsby-transformer-sharp/src/customize-schema.js Co-authored-by: Matt Kane <matt@gatsbyjs.com> * work for fixed too Co-authored-by: Matt Kane <matt@gatsbyjs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to the new image suite for passing a specific aspect ratio that will recalculate the height of the image and process/crop accordingly.
Right now this is implemented for maxWith/maxHeight and fluid/constrained images so that the migration to new defaults will change everything at the same time. [ch22093]