Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change fluid to fullWidth #28987

Merged
merged 10 commits into from
Jan 12, 2021
Merged

chore: change fluid to fullWidth #28987

merged 10 commits into from
Jan 12, 2021

Conversation

laurieontech
Copy link
Contributor

@laurieontech laurieontech commented Jan 11, 2021 •
edited

This API change better reflects functionality. And it points people to constrained which is what they want in most cases.

TODO:

[ch22725]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 11, 2021
@laurieontech laurieontech added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 11, 2021
@laurieontech laurieontech marked this pull request as ready for review January 12, 2021 17:03
LB and others added 2 commits January 12, 2021 12:07
@ascorbic
Update packages/gatsby-plugin-image/README.md
9417c90 
Co-authored-by: Matt Kane <matt@gatsbyjs.com>
conflict
6d35c41
ascorbic
ascorbic approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@laurieontech laurieontech added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 12, 2021
@gatsbybot gatsbybot merged commit 381e13c into master Jan 12, 2021
@gatsbybot gatsbybot deleted the rename-fluid branch January 12, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@laurieontech @ascorbic @gatsbybot