Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-image): Use inline-block in class so users can override #29148

Merged
merged 7 commits into from
Jan 25, 2021

Conversation

laurieontech
Copy link
Contributor

Constrained images were getting an inline style of inline-block which users could not override without a !important. We consider that too opinionated but it's a necessary fallback when images are not otherwise in a container with a display rule.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 22, 2021
@laurieontech laurieontech added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 22, 2021
@laurieontech laurieontech added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 25, 2021
@laurieontech laurieontech merged commit f945049 into master Jan 25, 2021
@laurieontech laurieontech deleted the images/css-to-class branch January 25, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants