fix(gatsby-plugin-image): Handle breakpoints and auto-format in plugin utils #29187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
added
topic: media
| @@ -4,7 +4,21 @@ import { IGatsbyImageData } from "." | |||
| import type sharp from "gatsby-plugin-sharp/safe-sharp" | |||
|
|
|||
| const DEFAULT_PIXEL_DENSITIES = [0.25, 0.5, 1, 2] | |||
| const DEFAULT_BREAKPOINTS = [750, 1080, 1366, 1920] | |||
| export const DEFAULT_BREAKPOINTS = [750, 1080, 1366, 1920] | |||
| export const EVERY_BREAKPOINT = [ | |||
There was a problem hiding this comment.
Is our default for hooks really going to be all of these?
There was a problem hiding this comment.
It's for plugins that don't do any actual resizing, so passing more breakpoints just makes it more likely that there will be one that is the size of the screen
There was a problem hiding this comment.
Ah, that makes sense.
laurieontech
approved these changes
Jan 25, 2021
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes are mainly for image providers that generate images on the fly. It correctly handles auto fileformats, for image hosts that use content negotiation instead (like Cloudinary), where prviously it was failing to generate the img tag. It also adds a large number of breakpoints by default, as they're effectively free.