Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-image): Correct default enum value #29607

Merged
merged 1 commit into from
Feb 19, 2021
Merged

fix(gatsby-plugin-image): Correct default enum value #29607

merged 1 commit into from
Feb 19, 2021

Conversation

ascorbic
Copy link
Contributor

Although the ENUM is [AUTO, WEBP], the string value of AUTO is "", so this was causing errors.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 19, 2021
laurieontech
laurieontech approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ascorbic ascorbic added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 19, 2021
@gatsbybot gatsbybot merged commit 7e8b91c into master Feb 19, 2021
@gatsbybot gatsbybot deleted the fix/imageformat-enum branch February 19, 2021 16:54
This was referenced Mar 16, 2021
Merged
Merged
Closed
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurieontech laurieontech laurieontech approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ascorbic @laurieontech @gatsbybot