fix(gatsby-source-wordpress): image fixes #29813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
TylerBarnes
removed
the
status: triage needed
TylerBarnes
changed the title
wardpeet
reviewed
Feb 28, 2021
...rce-wordpress/src/steps/source-nodes/create-nodes/create-remote-file-node/create-progress.js
Outdated
Show resolved
Hide resolved
wardpeet
reviewed
Feb 28, 2021
| normalizedMatch + `(?!/?wp-content|/?wp-admin|/?wp-includes)`, | ||
| `g` | ||
| ) | ||
|
|
||
| nodeString = nodeString.replace(thisMatchRegex, normalizedPath) |
There was a problem hiding this comment.
It's always helpful to add a comment with an example of what this converts into
wardpeet
reviewed
Feb 28, 2021
Comment on lines
+142
to
+143
| console.error(error) | ||
| reporter.panic() |
There was a problem hiding this comment.
What's wrong with panicking with an error?
Suggested change
| console.error(error) | |
| reporter.panic() | |
| reporter.panic(error) |
There was a problem hiding this comment.
reporter.panic() is broken right now - this will result in Gatsby logging "There was an error" and quitting with no additional info https://gatsby.canny.io/ideas/p/reporterpanic-is-broken
wardpeet
reviewed
Feb 28, 2021
wardpeet
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
@TylerBarnes I published it in gatsby-source-wordpress@wp-fixes
The cherry-pick into v2 will need the createProgressbar fix but that needs to be done in the cherry-pick PR and not in the master PR.
sslotsky
approved these changes
Mar 1, 2021
ascorbic
pushed a commit
that referenced
this pull request
Mar 1, 2021
Co-authored-by: Ward Peeters <ward@coding-tech.com> (cherry picked from commit 28124dd)
vladar
pushed a commit
that referenced
this pull request
Mar 1, 2021
Co-authored-by: Ward Peeters <ward@coding-tech.com> (cherry picked from commit 28124dd)
This was referenced Mar 26, 2024
This was referenced Mar 26, 2024
This was referenced Mar 27, 2024
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of 3 quick/emergency fixes.
I was debugging a customer site and found that in their case these 3 things were broken (all related to transforming images in html or file connection fields). This is a single PR because these all need to be fixed for that feature to work.
1a61ee7 and a9b139c are permanent fixes.
4226459 isn't great and has a bit of a back-story. Early on in this plugins development I copied over create-remote-file-node to the WP plugin to debug some things - I ended up changing it quite a bit and never PR'ed the fixes back to core (bad monkey! 🙈). Well my copied version is importing an export from gatsby-source-filesystem that no longer exists.. which isn't great. This is a temporary fix and the copied create-remote-file-node will be removed soon - in the meantime we need to fix it like this.