Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(gatsby-plugin-sass): Change modules option around" #30038

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Revert "fix(gatsby-plugin-sass): Change modules option around" #30038

merged 1 commit into from
Mar 5, 2021

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Mar 5, 2021 •
edited

Reverts #29986

fixes #30037 30037

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 5, 2021
@wardpeet wardpeet added topic: sass and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 5, 2021
@wardpeet wardpeet added this to To cherry-pick in V3 Release Hotfixes via automation Mar 5, 2021
@pieh pieh mentioned this pull request Mar 5, 2021
Closed
@vladar vladar merged commit 0f4de9d into master Mar 5, 2021
@vladar vladar deleted the revert-29986-sass-29955 branch March 5, 2021 20:01
vladar pushed a commit that referenced this pull request Mar 5, 2021
@wardpeet @vladar
Revert "fix(gatsby-plugin-sass): Change modules option around (#29986…
d4f35a5 
…)" (#30038)

This reverts commit bba21cd.

(cherry picked from commit 0f4de9d)
@gatsbybot gatsbybot mentioned this pull request Mar 5, 2021
Merged
@vladar vladar moved this from To cherry-pick to Backport PR opened in V3 Release Hotfixes Mar 5, 2021
vladar pushed a commit that referenced this pull request Mar 5, 2021
@wardpeet
Revert "fix(gatsby-plugin-sass): Change modules option around (#29986…
1acdbb6 
…)" (#30038) (#30050)

This reverts commit bba21cd.

(cherry picked from commit 0f4de9d)

Co-authored-by: Ward Peeters <ward@coding-tech.com>
@vladar vladar moved this from Backport PR opened to Backported in V3 Release Hotfixes Mar 5, 2021
@vladar
Copy link
Contributor

vladar commented Mar 5, 2021

Published in gatsby-plugin-sass@4.0.2

@pieh pieh mentioned this pull request Mar 8, 2021
Merged
@vladar vladar moved this from Backported to Archived in V3 Release Hotfixes Mar 9, 2021
This was referenced Mar 17, 2021
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
V3 Release Hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gatsby-plugin-sass no longer imports module styles as of 4.0.1
3 participants
@wardpeet @vladar @pieh