Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust npm release dist tag for v2 #30090

Merged
merged 1 commit into from Mar 8, 2021
Merged

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Mar 8, 2021

Description

V3 is out and this should be latest, but we still will be releasing patches for v2 so those stable releases should not be tagged as latest

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 8, 2021
@@ -146,7 +146,7 @@
"publish-preminor": "node scripts/clear-package-dir preminor --verbose && lerna publish preminor --pre-dist-tag=next --preid=next --force-publish --allow-branch=master --message=\"chore(release): Publish next pre-minor\"",
"publish-next": "node scripts/clear-package-dir prerelease --verbose && lerna publish prerelease --pre-dist-tag=next --preid=next --allow-branch=master --message=\"chore(release): Publish next\"",
"publish-rc": "node scripts/clear-package-dir prerelease --verbose && lerna publish prerelease --pre-dist-tag=rc --preid=rc --message=\"chore(release): Publish rc\"",
"publish-release": "node scripts/clear-package-dir patch --verbose && lerna publish patch",
"publish-release": "node scripts/clear-package-dir patch --verbose && lerna publish patch --dist-tag=latest-v2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about convention for that - but this is following one we had for v1 (latest-vX)

@pieh pieh added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 8, 2021
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea if people actually use tags for this. I usually do npm install gatsby@^2.0.0. So if we did latest-v1 in previous major, let's stick with it.

@pieh pieh merged commit 4abcb15 into release/2.32 Mar 8, 2021
@pieh pieh deleted the 2.32-publish-dist-tag branch March 8, 2021 13:31
@pieh
Copy link
Contributor Author

pieh commented Mar 8, 2021

no idea if people actually use tags for this. I usually do npm install gatsby@^2.0.0.

This is mainly for publishing purposes, because afaik dist-tag need to be set, and if not specified latest would be used (and we don't want latest to point to v2 releases). Completely agree that consumers likely won't use/need this as even when installing npm install gatsby@latest-v2 it will write ^2.32.X in package.json so upgrading will keep using version selector and not dist tag selector

This was referenced Mar 9, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants