Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-image): Handle placeholder in plugin toolkit #30141

Merged
merged 2 commits into from
Mar 10, 2021
Merged

fix(gatsby-plugin-image): Handle placeholder in plugin toolkit #30141

merged 2 commits into from
Mar 10, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Mar 9, 2021

We are currently not passing through the placeholder URL in the image plugin toolkit, so blurred and traced SVG placeholders aren't working properly.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 9, 2021
@ascorbic ascorbic added this to To cherry-pick in V3 Release Hotfixes via automation Mar 9, 2021
@ascorbic ascorbic added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 9, 2021
@ascorbic ascorbic merged commit f851312 into master Mar 10, 2021
@ascorbic ascorbic deleted the fix/imagedata-placeholder branch March 10, 2021 09:32
vladar pushed a commit that referenced this pull request Mar 10, 2021
@ascorbic @vladar
fix(gatsby-plugin-image): Handle placeholder in plugin toolkit (#30141)
9fb56ac 
* fix(gatsby-plugin-image): Handle placeholder in plugin toolkit

* Add test

(cherry picked from commit f851312)
vladar pushed a commit that referenced this pull request Mar 10, 2021
@ascorbic @vladar
fix(gatsby-plugin-image): Handle placeholder in plugin toolkit (#30141)
a348ab9 
* fix(gatsby-plugin-image): Handle placeholder in plugin toolkit

* Add test

(cherry picked from commit f851312)
@gatsbybot gatsbybot mentioned this pull request Mar 10, 2021
Merged
@vladar vladar moved this from To cherry-pick to Backport PR opened in V3 Release Hotfixes Mar 10, 2021
vladar pushed a commit that referenced this pull request Mar 10, 2021
@ascorbic
fix(gatsby-plugin-image): Handle placeholder in plugin toolkit (#30141)…
4c44125 
… (#30170)

* fix(gatsby-plugin-image): Handle placeholder in plugin toolkit

* Add test

(cherry picked from commit f851312)

Co-authored-by: Matt Kane <matt@gatsbyjs.com>
@vladar vladar moved this from Backport PR opened to Backported in V3 Release Hotfixes Mar 10, 2021
@vladar
Copy link
Contributor

vladar commented Mar 10, 2021

Published in gatsby-plugin-image@1.0.1

This was referenced Mar 10, 2021
Merged
Merged
Closed
Closed
@vladar vladar moved this from Backported to Archived in V3 Release Hotfixes Mar 15, 2021
This was referenced Mar 16, 2021
Merged
Merged
Closed
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
No open projects
V3 Release Hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ascorbic @vladar @LekoArts