Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-source-wordpress): updates for gatsby v3 #30281

Merged
merged 4 commits into from
Mar 26, 2021

Conversation

TylerBarnes
Copy link
Contributor

@TylerBarnes TylerBarnes commented Mar 17, 2021

This PR:

  • Updates touchNode and deleteNode signatures for v3
  • Updates schema customization to use node interface inheritance instead of the @nodeInterface directive
  • Patches a bug I noticed while making these changes where duplicate nodes are incorrectly logged during delta updates

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 17, 2021
@TylerBarnes TylerBarnes removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 17, 2021
@TylerBarnes TylerBarnes added the topic: source-wordpress Related to Gatsby's integration with WordPress label Mar 18, 2021
@TylerBarnes TylerBarnes marked this pull request as ready for review March 18, 2021 17:46
sslotsky
sslotsky previously approved these changes Mar 18, 2021
@TylerBarnes
Copy link
Contributor Author

I've moved the node interface updates to another PR as that change requires a core fix first #30496

@TylerBarnes TylerBarnes marked this pull request as ready for review March 26, 2021 14:50
@TylerBarnes
Copy link
Contributor Author

The failing tests here are unrelated to this PR

@TylerBarnes TylerBarnes merged commit ce4fcea into master Mar 26, 2021
@TylerBarnes TylerBarnes deleted the chore/update-wp-for-gatsby-v3 branch March 26, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-wordpress Related to Gatsby's integration with WordPress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants